Add Microsoft.Extensions.Options to dependencies - #30233
Draft
Yeming Liu (isra-fel) wants to merge 2 commits into
Draft
Yeming Liu (isra-fel) wants to merge 2 commits into
Yeming Liu (isra-fel) wants to merge 2 commits into
Conversation
Added Microsoft.Extensions.Options to the assembly resolver dependencies.
Contributor
|
Azure Pipelines: Successfully started running 2 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The required Accounts changelog entry is missing and will trigger repository validation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds cross-major assembly redirection for Microsoft.Extensions.Options to resolve dependency version conflicts.
Changes:
- Allows Az.Resources v2 requests to resolve against the shipped v10 assembly.
| File | Description |
|---|---|
src/Accounts/Authentication/Utilities/CustomAssemblyResolver.cs |
Adds Options to the redirection allowlist. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "System.Memory.Data", | ||
| "System.Text.Json", | ||
| "Microsoft.Bcl.AsyncInterfaces", | ||
| "Microsoft.Extensions.Options", // Azure.Identity depends on v10, Az.Resources depends on v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Microsoft.Extensions.Options to the assembly resolver dependencies.
Follow-up to #30231
Would solve the issue if the versions continue to drift.
Not a candidate for hotfix/oob cause 30231 would already mitigate the issue.
Todo: add changelog after release branch for az 16.4.0 is merged back to main; validate smoke test.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.