Repository navigation
[EngSys] Forward Rust opt-in parameters through Cosmos CI template - #49522
Merged
jenny (JennyPng) merged 1 commit intoOct 13, 2026
Merged
jenny (JennyPng) merged 1 commit into
jenny (JennyPng) merged 1 commit into
Conversation
Expose the four Rust build parameters in the Cosmos wrapper and forward them to archetype-sdk-client. Keep Rust disabled by default and leave feed selection to the caller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00cb7ea9-d85f-4bee-bfb3-e6c94f9d3b64
|
Azure Pipelines: Successfully started running 1 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
jenny (JennyPng)
marked this pull request as ready for review
October 13, 2026 19:59
jenny (JennyPng)
requested review from
Daniel Jurek (danieljurek) and
Libba Lawrence (l0lawrence)
as code owners
October 13, 2026 19:59
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new Cosmos forwarding layer is missing coverage in the existing native-build pipeline contract test.
1 open finding
What changed in this PR
Enables Cosmos CI to opt into the shared Microsoft Rust toolchain setup without activating it by default.
Changes:
- Adds four Rust configuration parameters with shared defaults.
- Forwards them to the SDK client archetype.
| File | Description |
|---|---|
eng/pipelines/templates/stages/cosmos-sdk-client.yml |
Exposes and forwards Rust opt-in settings. |
🧠 Review effort: Balanced
Libba Lawrence (l0lawrence)
approved these changes
Oct 13, 2026
jenny (JennyPng)
enabled auto-merge (squash)
October 13, 2026 20:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #49397.
InstallMsRustToolchain,MsRustWorkingDirectory,MsRustToolchainFeed, andMsRustAdditionalTargetsfromcosmos-sdk-client.ymltoarchetype-sdk-client.yml.sdk/cosmos/ci.yml. This PR does not activate Rust or select a toolchain feed.