Skip to content

[ML] Avoid secret-scanning false positive in named OneLake test #49835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kashif Khan (kashifkhan) merged 3 commits into from
Nov 5, 2026
Merged

[ML] Avoid secret-scanning false positive in named OneLake test #49835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0ff63
test(ml): avoid credential-shaped OneLake URI fixture
vaibhj Nov 5, 2026
9038482
chore(ml): add requested code owners
vaibhj Nov 5, 2026
0377874
chore(ml): revise requested code owner additions
vaibhj Nov 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,10 @@
/sdk/loadtesting/azure-developer-loadtesting/ @mitsha-microsoft @ninallam @prativen

# PRLabel: %Machine Learning
/sdk/ml/ @achauhan-scc @jayesh-tanna @kingernupur
/sdk/ml/ @achauhan-scc @jayesh-tanna @kingernupur @novaturient95 @viragjain611

# PRLabel: %Machine Learning
/sdk/ml/azure-ai-ml/ @achauhan-scc @arunsu @jayesh-tanna @jialiu103 @JustinFirsching @kingernupur @nick863 @NonStatic2014 @novaturient95 @PhaniShekhar @raduk @rtanase @sharma-riti @vivram @yuanzhuangyuanzhuang
/sdk/ml/azure-ai-ml/ @achauhan-scc @arunsu @jayesh-tanna @jialiu103 @JustinFirsching @kingernupur @nick863 @NonStatic2014 @novaturient95 @PhaniShekhar @raduk @rtanase @sharma-riti @viragjain611 @vivram @yuanzhuangyuanzhuang

# ServiceLabel: %Machine Learning
# ServiceOwners: @Azure/azure-ml-sdk @azureml-github
Expand Down
8 changes: 7 additions & 1 deletion sdk/ml/azure-ai-ml/tests/dataset/unittests/test_data_path_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# ---------------------------------------------------------

from unittest.mock import Mock, patch
from urllib.parse import urlsplit

import pytest
import yaml
Expand Down Expand Up @@ -119,7 +120,12 @@ def test_named_onelake_artifact_and_subpath(operations):
store.artifact.name = "lake/Files"
store.endpoint = "onelake.dfs.fabric.microsoft.com"
result = _DataPathResolver(operations, False).resolve("azureml://datastores/fabric/paths/data.csv")
assert result.uri == "abfss://workspace@onelake.dfs.fabric.microsoft.com/lake.lakehouse/Files/data.csv"
resolved = urlsplit(result.uri)
assert resolved.scheme == "abfss"
assert resolved.netloc == "@".join((store.one_lake_workspace_name, store.endpoint))
assert resolved.path == "/lake.lakehouse/Files/data.csv"
assert not resolved.query
assert not resolved.fragment


@pytest.mark.parametrize(
Expand Down
Loading