Skip to content

[Follow-up to #49368] Recover incoming pyAMQP windows - #49953

Draft
S.J. (cstolting-collab) wants to merge 1 commit into
Azure:fix/pyamqp-session-window-49232from
cstolting-collab:review/pyamqp-incoming-only-49368
Draft

S.J. (cstolting-collab) wants to merge 1 commit into
Azure:fix/pyamqp-session-window-49232from
cstolting-collab:review/pyamqp-incoming-only-49368

Conversation

@cstolting-collab

Copy link
Copy Markdown

A receive-side link handler failure can bypass incoming-window replenishment on #49368. The asynchronous unattached-handle path can also advertise receive capacity during teardown. This draft adds the incoming correction directly to EldertGrootenboer's branch while preserving its outgoing-credit, fragmentation, and concurrency implementation.

Scope and relationship

Validation

The November 11 inspection independently reran the focused unit selection:

Published commit: c57983c591ca560a16d417a723da8f58485edc6f.
Exact tested/published Git tree: e58e5e8d910e3a9081dcfd637284e204b5f79549.
Local pre-merge correction commit: a84cd076286445adffbc3a306ee35dffdd5514dd.
Publication recreated the commit through GitHub with the same complete tree and the same sole parent; no existing branch history was rewritten.

Tests used Linux/Python 3.12.14 and checked-out package sources via PYTHONPATH, with --noconftest --import-mode=importlib. This is a focused pure-unit selection with mocks, not complete package or live-broker validation. Handler and FLOW failures are exercised separately; no simultaneous-failure exception-priority guarantee is asserted. Historical lint results are retained with #49947's evidence and were not rerun for this packaging-only publication.

CI and handoff

Remote build/test validation of this new commit is pending. The relevant automatic pipeline branch filters do not include the fix/* target, so successful local tests must not be treated as successful remote CI; an authorized maintainer may need to arrange a run.

#49947 and its original branch/evidence are preserved as the historical integration attempt. This draft is the focused review vehicle for the incoming-only correction.

Contribution checklist

  • No public API or intended breaking changes.
  • Chronus change entry supplied for both packages; main/changelog synchronization is separate.
  • Contribution guidance reviewed; one focused commit with regression coverage.

Apply the seven-file incoming-only correction on Azure#49368. Preserve
existing outgoing-credit, fragmentation, and concurrency behavior.

Tree-identical to locally validated commit a84cd076286445adffbc3a306ee35dffdd5514dd.
Replaces the oversized review packaging in Azure#49947 without main synchronization.
@azure-sdk-automation

Copy link
Copy Markdown
Contributor

The sdk-api-review-ready label cannot create a review PR for this working PR because its branch is in a fork repository. Prefer a working branch in the registered upstream repository, or reach out to the ARH maintainers for help. Fork reviews are supported through the Azure SDK CLI (azsdk apireview create), but the fork requires its own ARH registration and the review PR is created in the fork rather than the upstream repository.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
8 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@github-actions github-actions Bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs Service Bus labels Nov 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution S.J. (@cstolting-collab)! We will review the pull request and get back to you soon.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant