Repository navigation
[Follow-up to #49368] Recover incoming pyAMQP windows - #49953
Draft
S.J. (cstolting-collab) wants to merge 1 commit into
Draft
S.J. (cstolting-collab) wants to merge 1 commit into
S.J. (cstolting-collab) wants to merge 1 commit into
Conversation
Apply the seven-file incoming-only correction on Azure#49368. Preserve existing outgoing-credit, fragmentation, and concurrency behavior. Tree-identical to locally validated commit a84cd076286445adffbc3a306ee35dffdd5514dd. Replaces the oversized review packaging in Azure#49947 without main synchronization.
Contributor
|
The |
|
Azure Pipelines: 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Thank you for your contribution S.J. (@cstolting-collab)! We will review the pull request and get back to you soon. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A receive-side link handler failure can bypass incoming-window replenishment on #49368. The asynchronous unattached-handle path can also advertise receive capacity during teardown. This draft adds the incoming correction directly to EldertGrootenboer's branch while preserving its outgoing-credit, fragmentation, and concurrency implementation.
Scope and relationship
fix/pyamqp-session-window-49232at8c13500388c7330820d53a7bac27c116cfedd339.finally, only while the session isMAPPEDandincoming_window <= 0.mainor its two changelog conflict resolutions. Main synchronization remains a separate owner integration decision.Validation
The November 11 inspection independently reran the focused unit selection:
8c13500388c7330820d53a7bac27c116cfedd339, the new 54-case selection produced 36 failures and 18 passes._incoming_transfer; its other implementation files remain unchanged.git diff --check.Published commit:
c57983c591ca560a16d417a723da8f58485edc6f.Exact tested/published Git tree:
e58e5e8d910e3a9081dcfd637284e204b5f79549.Local pre-merge correction commit:
a84cd076286445adffbc3a306ee35dffdd5514dd.Publication recreated the commit through GitHub with the same complete tree and the same sole parent; no existing branch history was rewritten.
Tests used Linux/Python 3.12.14 and checked-out package sources via
PYTHONPATH, with--noconftest --import-mode=importlib. This is a focused pure-unit selection with mocks, not complete package or live-broker validation. Handler and FLOW failures are exercised separately; no simultaneous-failure exception-priority guarantee is asserted. Historical lint results are retained with #49947's evidence and were not rerun for this packaging-only publication.CI and handoff
Remote build/test validation of this new commit is pending. The relevant automatic pipeline branch filters do not include the
fix/*target, so successful local tests must not be treated as successful remote CI; an authorized maintainer may need to arrange a run.#49947 and its original branch/evidence are preserved as the historical integration attempt. This draft is the focused review vehicle for the incoming-only correction.
Contribution checklist