Repository navigation
Run the two-human-reviewers gate on pull_request instead of pull_request_target - #379
Open
Parth Aggarwal (parth21999) wants to merge 1 commit into
Open
Parth Aggarwal (parth21999) wants to merge 1 commit into
Parth Aggarwal (parth21999) wants to merge 1 commit into
Conversation
…est_target GitHub starts blocking pull_request_target by default in public repositories on November 2, 2026. Update the caller to the new template from Azure/c-build-tools#475. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e7c537a1-1b1b-413e-9943-8d3174d1c5ce
Member
Author
|
/azp run Azure-c-testrunnerswitcher-Gate |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Parth Aggarwal (parth21999)
enabled auto-merge (squash)
October 22, 2026 19:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub starts blocking
pull_request_targetby default in public repositories on November 2, 2026 (default policy). This updates.github/workflows/two-human-reviewers.ymlto the new caller template from Azure/c-build-tools#475, and doesn't need that PR to merge first.pull_requestinstead ofpull_request_target, with the same activity types. Thepull_request_reviewandworkflow_dispatchtriggers, the permissions and themrbot/two-human-reviewersstatus are unchanged.Fork PRs: a fork's
pull_requestrun gets a read-only token, so it can't publish the status, and the PR stays blocked until a maintainer publishes it with Run workflow on the Actions tab, or:Run it again after each push.
Validation: this PR's own
pull_requestrun publishedmrbot/two-human-reviewers= success on a re-run. Its first attempt hit a transient publish failure, whichmaster'spull_request_targetrun also hit at the same moment.