Repository navigation
[MrBot] lackey dll: no logger init/deinit in DllMain - #685
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
Author
|
/AzurePipelines run |
samrach9
marked this pull request as ready for review
October 19, 2026 19:14
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
samrach9
enabled auto-merge (squash)
October 21, 2026 18:08
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes logger_init/logger_deinit (and the two LogError calls) from thread_notifications_lackey_dll DllMain, which now just returns TRUE. On ARM64 agents where symsrv.dll sits next to dbghelp.dll, logger_deinit at DLL_PROCESS_DETACH calls SymCleanup after symsrv.dll is already unloaded, killing the process before stdout is flushed (bs_no_replication_perf lost all output). Callers already log lackey init failures.