Select only changed live-test methods - #56
Merged
Merged
Conversation
Handle replacement hunks inside test methods without falling back to the entire file. Preserve conservative file-level fallback for shared helpers, imports, deletion-only changes, and ambiguous selectors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eb18b819-160c-48b7-a183-407ee5c12a2f
![x-engineering-agent[bot]](https://avatars.githubusercontent.com/in/4205534?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
az storage blob download-batch: Ensure downloaded blobs stay within the destination directory azure-cli#34126Root cause
The failed live-test run for Azure/azure-cli#34126 checked out the correct PR head (
f116f590) but treated replacement hunks as unsafe deletions and selected three entire test files. This ran 30 tests and failed first in unrelatedtest_storage_blob_batch_copy, whose unchanged preparer requested legacykind=Storage.With this change, the same PR revision selects only:
storage.test_storage_blob_batch_download_scenariosstorage.test_storage_blob_download_batch(new focused file)storage.test_storage_blob_batch_oauth_scenariosValidation
python3 -m unittest discover -s .github/scripts -p "test_*.py"(18 passed)f116f590a4910615264740f32c056655e5840342