Skip to content

docs(review): document field-index informer costs - #673

Merged
jmclong (jmclong) merged 1 commit into
mainfrom
dev/jlong/review-index-informer-cost
Oct 23, 2026
Merged

jmclong (jmclong) merged 1 commit into
mainfrom
dev/jlong/review-index-informer-cost

Conversation

@jmclong

Copy link
Copy Markdown
Contributor

Summary

  • Treat controller-runtime field-index registration as a potential informer dependency, not just a local lookup optimization.
  • Check informer reuse, full-object versus metadata caches, cache scope, startup synchronization, and DaemonSet fan-out.
  • Make explicit that a selective field index does not narrow the underlying LIST/WATCH.

Validation

  • pre-commit run --files .github/skills/code-review-scalability/SKILL.md passed all applicable hooks, including Markdown lint, spelling and link checks.
  • git diff --check passed.
  • Documentation-only change: seven added lines in one review skill; no runtime code changed. Repository-wide Go build/tests cannot exercise this change and were not run.

Prompted by the informer-cost review of #646.

Cover informer creation and reuse, cache scope, startup costs, and DaemonSet fan-out when reviewing field-index registration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 38825b3e-9a6d-4b27-8a56-16b529e39b00
@jmclong
jmclong (jmclong) merged commit a8241f4 into main Oct 23, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants