Repository navigation
ci(trivy): report amd64 image vulnerabilities to GitHub Security - #686
Merged
Merged
Conversation
Limit sidecar vulnerability scans to linux/amd64 and remove the ECR-only database override from all image scans. Keep vulnerability failure settings unchanged and update the chart documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b22cc4d-c0c5-4ee7-9bac-ce9a8221fe37
jmclong (jmclong)
requested review from
a team,
Simon Croome (croomes) and
Lana Andreasyan (landreasyan)
as code owners
October 28, 2026 13:01
Upload separate SARIF analyses for the driver, manager, and each sidecar on main and pull requests. Preserve fixable-vulnerability filtering without adding a critical-severity blocking step. Scanner and upload errors remain failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b22cc4d-c0c5-4ee7-9bac-ce9a8221fe37
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2b22cc4d-c0c5-4ee7-9bac-ce9a8221fe37
Hari (hasethuraman)
approved these changes
Oct 29, 2026
Hari (hasethuraman)
left a comment
Contributor
There was a problem hiding this comment.
FYI jmclong (@jmclong) After PR #686:
Scans still run and still find the same vulnerabilities.
They write SARIF and upload it with github/codeql-action/upload-sarif.
exit-code is set to 0, so the job succeeds even when critical findings exist.
Those findings become code scanning alerts instead of failing the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reason
Run 40670127144 failed downloading the vulnerability database from public ECR with TOOMANYREQUESTS: Data limit exceeded. Default mirrors avoid forcing every scan through that single registry. SARIF uploads make findings available for triage in GitHub Security instead of failing scan jobs for the existing vulnerability backlog.
Validation
Coverage
ARM64 sidecar images are intentionally no longer scanned by this workflow. Architecture build and test workflows are unchanged. This PR adds no vulnerability-severity gate and does not alter repository branch-protection or code-scanning rules.