Repository navigation
Crash if duplicate model names (across files) used in allOf #479
Description
A TSP conversion PR resulted in this error:
"details":"incompatible properties : tags
definitions/ContainerGroup/properties/tags
at file:///home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/ContainerInstance/stable/2025-09-01/containerInstance.json#L2245:8
definitions/Resource/properties/tags
at file:///home/runner/work/azure-rest-api-specs/azure-rest-api-specs/specification/containerinstance/resource-manager/Microsoft.ContainerInstance/ContainerInstance/stable/2025-09-01/containerInstance.json#L4642:8"
- https://github.com/Azure/azure-rest-api-specs/actions/runs/23628050434
- Migrate Containerinstance to TypeSpec azure-rest-api-specs#41602
Root cause, oad cannot handle two definitions in different files with the same name, if one definition is used in an allOf:
duplicate-names.json
{
"swagger": "2.0",
"info": {
"title": "duplicate-names",
"version": "1.0"
},
"paths": {},
"definitions": {
"Bar": {
"type": "object",
"properties": {
"p1": {
"type": "string"
}
},
"allOf": [
{
"$ref": "./common-types.json#/definitions/Foo"
}
]
},
"Foo": {
"type": "object",
"properties": {
"p1": {
"type": "object"
}
}
}
}
}common-types.json
{
"swagger": "2.0",
"info": {
"title": "common-types",
"version": "1.0"
},
"paths": {},
"definitions": {
"Foo": {
"type": "object",
"properties": {
"p1": {
"type": "string"
}
}
}
}
}test result
incompatible properties : p1
definitions/Bar/properties/p1
at file:///home/mharder/openapi-diff-mh/incompat-prop/src/test/specs/incompatible-properties/duplicate-names.json#L12:8
definitions/Foo/properties/p1
at file:///home/mharder/openapi-diff-mh/incompat-prop/src/test/specs/incompatible-properties/duplicate-names.json#L25:8
Reason, it assumes model names are unique across all files:
openapi-diff/src/lib/util/resolveSwagger.ts
Lines 346 to 352 in bb4653d
Related: #347
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
- Status
- Status
Activity
[-]error "incompatible properties" on unrelated types[/-][+]Crash if spec has two definitions with the same name in two files[/+][-]Crash if spec has two definitions with the same name in two files[/-][+]Crash if spec has two definitions of the same name[/+][-]Crash if spec has two definitions of the same name[/-][+]Crash if spec uses name in allof, and has two definitions of that name in different files[/+][-]Crash if spec uses name in allof, and has two definitions of that name in different files[/-][+]Crash if spec uses name in allOf, and has two definitions of that name in different files[/+][-]Crash if spec uses name in allOf, and has two definitions of that name in different files[/-][+]Crash if duplicate model names (across files) used in allOf[/+]pshao25 commentedon May 8, 2026
https://github.com/Azure/azure-rest-api-specs/actions/runs/25541171453 Is this related? I checked the "properties" property, but seems no duplicate.
mikeharder commentedon May 8, 2026
more likely related to: