[Parth Aggarwal (parth21999)]

Problem

A unit test that mocks c_pal (gballoc_hl, interlocked) cannot build a real configuration through fc_activation_context, its COM wrapper, DEFINE_SF_SERVICE_CONFIG and configuration_reader. Several links in that chain have no reals, so plain sf_c_util code runs inside the test and its gballoc, interlocked and rc_string calls land in the test's mocks:

• With interlocked mocked but not hooked, interlocked_decrement returns 0. The first Release of a configuration package frees it while the activation context still holds it, and the next read access violates in GetConfigurationPackage.
• With everything hooked, nothing crashes, but about 90 internal calls show up in umock's actual calls and break strict expectations.

Changes

Test code only; no changes under src or inc.

• real_configuration_reader (.c, .h, _renames.h).
• Reals for the COM wrappers of fc_activation_context, fc_package and fabric_string_list_result. Renaming the wrapped handle type renames every symbol com_wrapper.h generates.
• Missing dependency renames in the existing reals: real_fc_activation_context, real_fc_package, real_hresult_to_string, and string_utils in the argc/argv reals.
• real_sf_service_config.h. DEFINE_SF_SERVICE_CONFIG expands in the consumer, so sf_c_util cannot ship its real. The header documents how a consumer builds it and provides DECLARE_REAL_SF_SERVICE_CONFIG and REGISTER_SF_SERVICE_CONFIG_GLOBAL_MOCK_HOOK. real_sf_service_config_dependencies_renames.h renames everything the generated code calls.
• New real_sf_service_config_ut. It builds a configuration from argv entirely with reals, reads all 8 supported types, refreshes and releases it. It also asserts that the actual calls are exactly the top-level calls the test expects.

Consumer recipe:

// real_<consumer>_renames.h
#define my_service real_my_service
#define real_my_service_CONFIGURATION_TAG my_service_CONFIGURATION_TAG

// real_<consumer>.c
#include "real_sf_service_config_dependencies_renames.h"
#include "real_<consumer>_renames.h"
#include "../../src/<consumer>.c"

Testing

• Clean Debug x64 build with warnings as errors, configured with run_unittests, run_int_tests, run_reals_check, run_repo_validation and use_vld ON.
• 13 unit test executables (274 tests) and 11 integration test executables (172 tests) pass, with no VLD leaks.
• Reals check, traceability and repo validation pass.
• Removing any of the new renames makes real_sf_service_config_ut fail.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Parth Aggarwal (parth21999)]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines:
Successfully started running 1 pipeline(s).