Repository navigation
feat(react): transfer validation, overdraft prevention, submission states and receipt modal - #1282
Open
0xDeon wants to merge 1 commit into
Conversation
|
@0xDeon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…tes and receipt modal Closes BCPathway#1211, BCPathway#1212, BCPathway#1215, BCPathway#1216
p3ris0n
force-pushed
the
feature/1211-1212-1215-1216-transfer-screen-validation-receipt
branch
from
October 20, 2026 21:34
375a059 to
cb7ba5b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Phase 3 transfer flow in
TransferScreen:StrKey.isValidEd25519PublicKey; showsInvalid Stellar public key formatandCannot transfer to self.parsePositiveIntegerand compared with the live balance; showsInsufficient balanceand disables submit.TransferReceiptModal(sender, recipient, amount, timestamp, hash) withCopy Tx Hash,View on Explorer, and a balance refetch on confirmation.Exports
validateTransferDestination,validateTransferAmount,describeTransferError, andTransferReceiptModal. AddsexplorerUrlandonTransferConfirmedprops.Testing
npm run build --workspace @bc-forge/sdknpm test --workspace @bc-forge/react(283 passing)npm run build --workspace @bc-forge/reactNote: the existing test fixtures used addresses with invalid StrKey checksums; replaced with valid ones.
Closes #1211
Closes #1212
Closes #1215
Closes #1216
🤖 Generated with Claude Code