Repository navigation
Conversation
…view, and transfer form card Closes BCPathway#1207, Closes BCPathway#1208, Closes BCPathway#1209, Closes BCPathway#1210 - useSimulateTransaction: pre-flight simulateMint before signature, surfaces estimated fee, throws the RPC revert reason on failure (BCPathway#1207) - MintScreen: step-labelled progress modal (checking/signing/submitting) for the mint lifecycle (BCPathway#1208) - MintScreen: green success banner with copyable hash, ExternalLink to a block explorer, and a Mint another action (BCPathway#1209) - ExternalLink: shared safe-target-blank anchor component - TransferScreen: restyled as a form card with source, destination, amount, and transfer button, matching the MintScreen/MintForm design tokens (BCPathway#1210)
|
@Depo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 Mint/Transfer UI work, covering four linked issues:
useSimulateTransactionrunssimulateMintbefore prompting a wallet signature, surfaces the estimated resource fee, and shows the exact revert reason on a simulation failure (no signature prompt in that case).MintScreenshows a step-labelled progress indicator throughChecking transaction…→Waiting for signature…→Submitting to Stellar….ExternalLinkto a block explorer (via the newexplorerUrlprop), and a "Mint another" action that resets the form.TransferScreenrestyled as a form card with source address (connected, read-only), destination input, amount input, balance display, and a transfer button, matchingMintScreen/MintForm's design tokens.Changes
react/src/hooks.ts: newuseSimulateTransactionhook (simulateMintpre-flight, loading/error state, extractsminResourceFee).react/src/components/ExternalLink.tsx(+test): small shared anchor that always openstarget="_blank" rel="noreferrer noopener".react/src/screens/MintScreen.tsx(+test): simulate → confirm → submit → success flow described above.react/src/screens/TransferScreen.tsx: card layout, usesthemetokens.react/src/components/index.ts: exportExternalLink.Testing
npm run build --workspace @bc-forge/sdknpm test --workspace @bc-forge/react— 21 suites / 279 tests passingnpm run build --workspace @bc-forge/reactnpm run lintinreact/— no new errors introduced (pre-existingConnectionStatusBar.tsx/context.tsxno-explicit-anyandset-state-in-effectfindings are unrelated to this change)Closes #1207
Closes #1208
Closes #1209
Closes #1210
🤖 Generated with Claude Code