[정현수_Android] 9-1주차 과제 제출 - #10
Open
Rickettsia1234 wants to merge 6 commits into
Open
Conversation
JaeYoung290
reviewed
Jul 30, 2026
Collaborator
There was a problem hiding this comment.
추후 clean architecture 설계를 할 때는 domain, data 계층을 분리하시면 더 좋을 것 같습니다(현재 과제에서는 선택사항이라 문제 없습니다).
예를 들어 실제 데이터를 저장하는 기능을 구현한다면 직접적으로 로컬db나 api로 데이터를 조회하는 로직은 data 계층, 이것에 대한 추상 인터페이스를 domain 계층에 두고 viewmodel이 domain 계층에 의존성을 가지도록 구현 가능합니다.
Comment on lines
+25
to
+29
| if (data != null) { | ||
| val mode = data.getStringExtra("mode") | ||
| val word = data.getStringExtra("word").orEmpty() | ||
| val meaning = data.getStringExtra("meaning").orEmpty() | ||
| val uri = data.getStringExtra("imageUri") |
Collaborator
There was a problem hiding this comment.
여기 있는 키들도 companion object에 상수로 선언하는 것이 좋아보입니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.