Skip to content

fix: 버전 업데이트 API 수정 - #2326

Merged
Soundbar91 merged 5 commits into
developfrom
fix/2325-version-update-api
Aug 10, 2026
Merged

fix: 버전 업데이트 API 수정#2326
Soundbar91 merged 5 commits into
developfrom
fix/2325-version-update-api

Conversation

@Soundbar91

@Soundbar91 Soundbar91 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

🔍 개요


🚀 주요 변경 내용

  • AI 업무 자동화를 위한 어드민 버전 업데이트 API를 수정했습니다.
    • Version이 Platform 이외일 경우 업데이트가 되지 않는 것을 수정했습니다.

💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

Summary by CodeRabbit

  • New Features
    • Added support for updating both platform and non-platform version information.
    • Platform version updates continue creating a new version while preserving previous-version history.
    • Non-platform version updates now modify existing version details directly.
    • Expanded supported version types to include timetable and bus schedule versions.

@Soundbar91 Soundbar91 self-assigned this Aug 7, 2026
@github-actions github-actions Bot added 기능 새로운 기능을 개발합니다. 버그 정상적으로 동작하지 않는 문제상황입니다. labels Aug 7, 2026
@github-actions
github-actions Bot requested review from BaeJinho4028 and dh2906 August 7, 2026 09:32
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ee27bc8f-dcc5-45ac-8c7a-a63394ccaeaa

📥 Commits

Reviewing files that changed from the base of the PR and between 03d86c9 and 2047fab.

📒 Files selected for processing (1)
  • src/main/java/in/koreatech/koin/admin/version/controller/AdminVersionApi.java

📝 Walkthrough

Walkthrough

The admin version update flow now supports platform and non-platform versions. Platform versions keep the archive-and-create flow. Non-platform versions update the existing entity fields through a new Version.update method.

Changes

Version update behavior

Layer / File(s) Summary
Version entity update contract
src/main/java/in/koreatech/koin/domain/version/model/Version.java
Adds Version.update(String version, String title, String content) to replace the entity fields.
Admin version update branching
src/main/java/in/koreatech/koin/admin/version/service/AdminVersionService.java, src/main/java/in/koreatech/koin/admin/version/controller/AdminVersionApi.java
Keeps the archive-and-create flow for platform versions. Updates existing non-platform versions instead of throwing VersionNotSupportedException. Documents four additional supported version types and removes the unused exception import.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: baejinho4028, dh2906

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: fixing the version update API.
Linked Issues check ✅ Passed The changes address the linked issue by fixing admin version updates for non-platform versions and expanding the endpoint documentation. [#2325]
Out of Scope Changes check ✅ Passed The changes remain within scope because they update version handling and document the supported version types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/2325-version-update-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Unit Test Results

779 tests   776 ✔️  2m 11s ⏱️
188 suites      3 💤
188 files        0

Results for commit 2047fab.

♻️ This comment has been updated with latest results.

@Soundbar91
Soundbar91 merged commit f59c72e into develop Aug 10, 2026
7 checks passed
@Soundbar91
Soundbar91 deleted the fix/2325-version-update-api branch August 10, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

기능 새로운 기능을 개발합니다. 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[어드민] 버전 수정 API 수정

2 participants