Repository navigation
Structure_Engine: Add support for ConnectionForce fragments and refactor takeoffs - #3608
peterjamesnugent merged 23 commits into
Conversation
Piles where not handling ReinforcementDensities befoew and were hence giving errors. This has been amended in this testfile. Appart from that, the file runs as expected with the previous methods
Was failing due to change in order of materials of new methods. Now the reinforcement is always applied last which was not the case before, especially not for topped slabs.
|
@BHoMBot check unit-tests |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 39 requests in the queue ahead of you. |
…ies and toplevel reinforcementdensity being applied to non-concrete piles for PileFOundation
|
@IsakNaslundBh just to let you know, I have provided a |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 14 requests in the queue ahead of you. |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
peterjamesnugent
left a comment
peterjamesnugent
left a comment
There was a problem hiding this comment.
Some comments on the code, nothing major. I can do some testing with the script tomorrow - had a brief look at it and looks good.
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
Co-authored-by: Peter Nugent <Peter.Nugent@burohappold.com>
just removed the word completely in general rather than replacing with transversal. The context is implicit by the method anyway
|
@BHoMBot check unit-tests |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 22 requests in the queue ahead of you. |
|
THanks for the review @peterjamesnugent . THink I have adressed all of your comments - this should be good to go now! |
Iain11
left a comment
Iain11
left a comment
There was a problem hiding this comment.
Hand calculated the volume and mass for all the bars in the first and second group, the c24 CLT floor framing and the first foundation object (S235, C12/15, C12/15 & B500B). No discrepancies were found.
|
@BHoMBot check ready-to-merge |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
From offline conversation with @peterjamesnugent I am dismissing this after Iains review.
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 16 requests in the queue ahead of you. |
peterjamesnugent
left a comment
peterjamesnugent
left a comment
There was a problem hiding this comment.
Alongside @Iain11 's testing, I have done some spot checks and run the script.
Happy to merge and happy that all my changes have been addressed.
NOTE: Depends on
BHoM/BHoM#1732
Issues addressed by this PR
Closes #3607
Change methodology for extracting materiality from structural elements from using the MaterialComposition to instead make use of the GeneralMaterialTakeoff method.
Gives better flexibility in quantities returned and also makes the addition of connectionallowance more straightforward
Test files
See:
BHoM/BHoM#1732
Changelog
Additional comments