Skip to content

BHoM_Engine #3616 fixing problem with mirroring and flipping tapered bar new #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Iain11 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

BHoM_Engine #3616 fixing problem with mirroring and flipping tapered bar new #3625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/Datasets/Spatial_Engine/Modify/Mirror.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion .ci/Datasets/Structure_Engine/Modify/Flip.json
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 1 addition & 4 deletions Structure_Engine/Modify/Flip.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
[Description("Flips the Bar geometry and the properties including releases, sectionproperty and orientation angle.")]
[Input("bar", "The Bar to flip.")]
[Output("bar", "The Bar with flipped end Nodes.")]
public static Bar Flip(this Bar bar)

Check warning on line 54 in Structure_Engine/Modify/Flip.cs

View workflow job for this annotation

GitHub Actions / ci-code-compliance

Structure_Engine/Modify/Flip.cs#L54 

Structure_Engine/Modify/Flip.cs#L54: Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType

Check warning on line 54 in Structure_Engine/Modify/Flip.cs

View check run for this annotation

BHoMBot-CI / code-compliance

Structure_Engine/Modify/Flip.cs#L54 

Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType
{
if (bar.IsNull())
return null;
Expand Down Expand Up @@ -117,7 +117,7 @@
[Description("Flips the curve layout, i.e. the start becomes the end and vice versa.")]
[Input("layout", "The curvlayout to flip.")]
[Output("layout", "The layout with a flipped location curve.")]
public static ICurveLayout Flip(this ICurveLayout layout)

Check warning on line 120 in Structure_Engine/Modify/Flip.cs

View workflow job for this annotation

GitHub Actions / ci-code-compliance

Structure_Engine/Modify/Flip.cs#L120 

Structure_Engine/Modify/Flip.cs#L120: Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType

Check warning on line 120 in Structure_Engine/Modify/Flip.cs

View check run for this annotation

BHoMBot-CI / code-compliance

Structure_Engine/Modify/Flip.cs#L120 

Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType
{
if (layout.IsNull())
return null;
Expand All @@ -144,7 +144,7 @@
[Description("Flips the location curve of the Edge, i.e. the start becomes the end and vice versa.")]
[Input("edge", "The Edge to flip.")]
[Output("edge", "The Edge with a flipped location curve.")]
public static Edge Flip(this Edge edge)

Check warning on line 147 in Structure_Engine/Modify/Flip.cs

View workflow job for this annotation

GitHub Actions / ci-code-compliance

Structure_Engine/Modify/Flip.cs#L147 

Structure_Engine/Modify/Flip.cs#L147: Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType

Check warning on line 147 in Structure_Engine/Modify/Flip.cs

View check run for this annotation

BHoMBot-CI / code-compliance

Structure_Engine/Modify/Flip.cs#L147 

Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType
{
if (edge.IsNull())
return null;
Expand All @@ -160,7 +160,7 @@
[Description("Flips the normal of the Stem.")]
[Input("stem", "The Stem to flip.")]
[Output("stem", "The Stem with flipped Normal.")]
public static Stem Flip(this Stem stem)

Check warning on line 163 in Structure_Engine/Modify/Flip.cs

View workflow job for this annotation

GitHub Actions / ci-code-compliance

Structure_Engine/Modify/Flip.cs#L163 

Structure_Engine/Modify/Flip.cs#L163: Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType

Check warning on line 163 in Structure_Engine/Modify/Flip.cs

View check run for this annotation

BHoMBot-CI / code-compliance

Structure_Engine/Modify/Flip.cs#L163 

Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType
{
if (stem.IsNull())
return null;
Expand Down Expand Up @@ -305,7 +305,7 @@
[Description("Flips the ILayout2D for it to be used with a flipped bar. This means flipping the layout around the XZ plane.")]
[Input("layout", "The ILayout2D to flip.")]
[Output("layout", "The layout with a flipped.")]
public static ILayout2D Flip(this ILayout2D layout)

Check warning on line 308 in Structure_Engine/Modify/Flip.cs

View workflow job for this annotation

GitHub Actions / ci-code-compliance

Structure_Engine/Modify/Flip.cs#L308 

Structure_Engine/Modify/Flip.cs#L308: Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType

Check warning on line 308 in Structure_Engine/Modify/Flip.cs

View check run for this annotation

BHoMBot-CI / code-compliance

Structure_Engine/Modify/Flip.cs#L308 

Modify methods should return void, or their return type should be different to the input type of their first parameter - For more information see https://bhom.xyz/documentation/DevOps/Code%20Compliance%20and%20CI/Compliance%20Checks/ModifyReturnsDifferentType
{
if (layout.IsNull())
return null;
Expand Down Expand Up @@ -440,14 +440,11 @@
for (int i = 0; i < oldProfile.Profiles.Values.Count; i++)
{
double key = keys[i];
newPositions.Add(1 - key);
newPositions.Add(key);
oldProfile.Profiles.TryGetValue(key, out IProfile newProfile);
newProfiles.Add(FlipProfile(newProfile as dynamic));
}

newProfiles.Reverse();
newPositions.Reverse();

return Spatial.Create.TaperedProfile(newPositions, newProfiles, oldProfile.InterpolationOrder);
}

Expand Down
Loading