Repository navigation
Conversation
Changed the way the method does the extension. Instead of rotating the coordinate system the arc is based on it uses the start angle as negative.
Iain11
requested review from
IsakNaslundBh,
al-fisher and
pawelbaran
as code owners
October 12, 2026 16:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Fixes the bug when extending an arc with a start angle that is not 0
Closes #3563
Changed the way the extend method extends arcs. The original script would alter the coordinate system of the arc to set angle 0 at the start of the arc. This created some problems when the start angle was set to something that was not 0. Instead the extension of the start is now calculated as a negative angle.
TestFile
OriginalTest
Original TestFile doesn't cover issue.
ForIssue