Repository navigation
Exisiting methods clean-up and new methods added - #105
Open
WojciechBuda00 wants to merge 14 commits into
Open
WojciechBuda00 wants to merge 14 commits into
WojciechBuda00 wants to merge 14 commits into
Conversation
pawelbaran
reviewed
Oct 21, 2026
| if (outer == null || line == null || plane == null) | ||
| return false; | ||
|
|
||
| Point mid = (line.Start + line.End) * 0.5; |
Member
There was a problem hiding this comment.
this is wrong actually, see example below:
Have a think how to fix it, very likely it will not be inside Clipper_Toolkit (as soon as it stops being a simple wrapper for Clipper).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM_Engine#3627
Issues addressed by this PR
Closes #104
Test files
Changelog
Additional comments