Repository navigation
Add new create methods for metrics and EPDs - #396
Merged
IsakNaslundBh merged 11 commits intoOct 23, 2026
Merged
IsakNaslundBh merged 11 commits into
IsakNaslundBh merged 11 commits into
Conversation
Adds a method that allow creation a metric based on a type and a provided dictionary of the factors. Usefull for adapters and similar to more easily generate the correct metric on the fly, without the need to hard-code for each type.
…uc and biogenic metrics and set of modules Usefull for manual creation of EPDs based on table
…tions for EnvironmentalMetric create method
…eateMethodsForMetrics
Removing the need to create a dictionary first, as well as allowing to create an empty one if downstream processes wants to handle the indicator assignments somewhere else. Also adding a 2-list input that allows for providing a list of modules as well as a list of factors
Folder was referencing an old interface name. Folder name should match the base interface for the types returned. This has no impact on the code as the namespace stays as it was
IsakNaslundBh
changed the title
Contributor
Author
|
@BHoMBot check core |
|
@IsakNaslundBh to confirm, the following actions are now queued:
|
|
Please be advised that the check with reference 116784670876 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 640 additional annotations waiting, made up of 0 errors and 640 warnings. |
Tom-Kingstone
approved these changes
Oct 23, 2026
Tom-Kingstone
left a comment
Tom-Kingstone
left a comment
Contributor
There was a problem hiding this comment.
Looks good and tests pass
Contributor
|
@BHoMBot check ready-to-merge |
|
@Tom-Kingstone to confirm, the following actions are now queued:
There are 26 requests in the queue ahead of you. |
IsakNaslundBh
deleted the
LifeCycleAssessment_Toolkit-#394-AddNewCreateMethodsForMetrics
branch
October 23, 2026 09:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #394
Adds two new Create methods
First one could ideally help simplify work done in things like adapters and similar, and help with more dynamic creation of metrics when for example a string or similar is known and can be turned into a MetricType enum
Second method is to help when generating EPDs more "By hand" for a list of written out values in for example excel or similar.
Also corrected a foldername that was incorrectly named (named after an old name ofr a interface).
Test files
Tests in unit-test project
Changelog
Additional comments