Skip to content

Update combination modules to make use of the new PartOfAttribute - #397

Open
IsakNaslundBh wants to merge 3 commits into
developfrom
LifeCycleAssessment_oM-#1758-AddNewPartOfAttributeToHandleCombinationModules
Open

IsakNaslundBh wants to merge 3 commits into
developfrom
LifeCycleAssessment_oM-#1758-AddNewPartOfAttributeToHandleCombinationModules

Conversation

@IsakNaslundBh

Copy link
Copy Markdown
Contributor

NOTE: Depends on

BHoM/BHoM#1759

Issues addressed by this PR

Makes use of the PartOf attribute to generate the CombinationModule dictionary.

This is moving the responsibility of looking after what is part of what from the hard-coded list to the oM. Making it a bit more clear, and not a hidden list in a method in the engine.

Test files

Existing unit-tests for combination module should cover this. They have not been updated, and should still pass.
This PR is not changing the behaviour, but jsut where the information is stored.

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh self-assigned this Oct 23, 2026
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Oct 23, 2026
Not technically needed right now, given the enum is defined in an order where combinations are always entered after their parts (for example B1toB7 is defined after B1toB5,B6andB7) but that technically could change in the future, and this change makes sure the data inserted is correctly capturing the order
@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check compliance

@bhombot-ci

bhombot-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 24 requests in the queue ahead of you.

Comment thread LifeCycleAssessment_Engine/Query/CombinationModules.cs Outdated
agree with that change

Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>

@Tom-Kingstone Tom-Kingstone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as tests passing with new PartOf attribute, and explanations are clear

@IsakNaslundBh

Copy link
Copy Markdown
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci

bhombot-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 21 requests in the queue ahead of you.

@bhombot-ci

bhombot-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci

bhombot-ci Bot commented Oct 23, 2026

Copy link
Copy Markdown

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New capability or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants