Repository navigation
Update combination modules to make use of the new PartOfAttribute - #397
Open
IsakNaslundBh wants to merge 3 commits into
Open
IsakNaslundBh wants to merge 3 commits into
IsakNaslundBh wants to merge 3 commits into
Conversation
Not technically needed right now, given the enum is defined in an order where combinations are always entered after their parts (for example B1toB7 is defined after B1toB5,B6andB7) but that technically could change in the future, and this change makes sure the data inserted is correctly capturing the order
Contributor
Author
|
@BHoMBot check compliance |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
agree with that change Co-authored-by: Thomas Edward Kingstone <Tom.Kingstone@burohappold.com>
Tom-Kingstone
approved these changes
Oct 23, 2026
Tom-Kingstone
left a comment
Contributor
There was a problem hiding this comment.
Approving as tests passing with new PartOf attribute, and explanations are clear
Contributor
Author
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 21 requests in the queue ahead of you. |
|
The check |
|
The check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#1759
Issues addressed by this PR
Makes use of the PartOf attribute to generate the CombinationModule dictionary.
This is moving the responsibility of looking after what is part of what from the hard-coded list to the oM. Making it a bit more clear, and not a hidden list in a method in the engine.
Test files
Existing unit-tests for combination module should cover this. They have not been updated, and should still pass.
This PR is not changing the behaviour, but jsut where the information is stored.
Changelog
Additional comments