Repository navigation
Add SetModuleValue method - #399
Open
IsakNaslundBh wants to merge 3 commits into
Open
IsakNaslundBh wants to merge 3 commits into
IsakNaslundBh wants to merge 3 commits into
Conversation
…arts and combinations are removed
Contributor
Author
|
@BHoMBot check compliance |
|
@IsakNaslundBh to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #398
Adds a method for settign one or more module values to both a dictionary as well as a IEnvironmentalMetric. The method has a boolean that if true (default value) ensures that any of the parts or combinations that could be invalidated by this operation are removed. This is, if A1 is set to a metric/dictionary containing A1toA3, then A1toA3 is removed, given the act of setting the value could (and most likely would) invalidate the value.
This new method is called by ResultingMetricValues. This method previously did the exact thing itself for any precomputed values. By centralising this method we allow for the same mechanism to be used from other places, such as other method calls, but also directly from the UI.
Test files
Unit-tests in test project should cover all edge-cases.
Changelog
Additional comments