Skip to content

Updated Connector Query to fallback to max distance if connector has no Origin, eg Logical Connectors #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michal-pekacki merged 1 commit into from
Jul 31, 2026
Merged

Updated Connector Query to fallback to max distance if connector has no Origin, eg Logical Connectors #1681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Revit_Core_Engine/Query/Connectors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ private static List<Connector> SortedConnectors(this MEPCurve mepCurve)
foreach (Connector conn in connSet)
connList.Add(conn);

connList = connList.OrderBy(x => x.Origin.DistanceTo(startPoint)).ToList();
// Order by distance from the start point. Logical connectors have no Origin, so they are sorted to the end rather than crashing the query.
connList = connList.OrderBy(x =>
{
try { return x.Origin.DistanceTo(startPoint); }
catch { return double.MaxValue; }
}).ToList();

return connList;
}
Expand Down
Loading