Repository navigation
Fork Sync Branch 18.0 - #13
Merged
Merged
Conversation
…hing The previous fix switched the purchase matching filter to qty_to_invoice for both bills and credit notes. That works for credit notes but breaks bills: on products controlled on received quantities, qty_to_invoice is qty_received - qty_invoiced, so a confirmed purchase order with no receipt yet gives 0 and every line was hidden from the matcher. Use the criterion that fits each document type instead: * in_invoice: product_qty > qty_invoiced, ie. ordered quantity not billed yet, received or not. * in_refund: qty_to_invoice < 0, ie. the pending credit left by a return on a line that is already fully billed. closes #353 Signed-off-by: Juan Carreras <jc@adhoc.com.ar>
sireko
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.