Skip to content

Register all export extensions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexchuber merged 4 commits into from
Sep 14, 2026
Merged

Register all export extensions #8

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e8a427
test: cover GLB texture extensions
alexchuber Sep 11, 2026
78e38fe
fix: register GLB export extensions
alexchuber Sep 11, 2026
c80fd54
test: move texture fixtures to helper
alexchuber Sep 14, 2026
2a2fcae
test: remove GLB texture internals
alexchuber Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions src/blocks/gltfOutputBlock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import type { BaseTexture } from "@babylonjs/core/Materials/Textures/baseTexture.js";
import type { Scene as BabylonScene } from "@babylonjs/core/scene.js";

import { BabylonSceneType } from "../connectionPoints/babylonScene";
Expand Down Expand Up @@ -31,11 +30,7 @@ export class GltfOutputBlock extends Block<typeof GltfOutputBlockDefinition> {
}

async function serializeGlbAsync(scene: BabylonScene, geometryCompressionOptions: GltfMeshCompressionOptions | undefined): Promise<File> {
if (scene.textures.some(requiresTextureTransform)) {
const { RegisterKHR_texture_transform } = await import("@babylonjs/serializers/glTF/2.0/Extensions/KHR_texture_transform.pure.js");
RegisterKHR_texture_transform();
}
const { GLTF2Export } = await import("@babylonjs/serializers/glTF/2.0/glTFSerializer.js");
const { GLTF2Export } = await import("@babylonjs/serializers/glTF/2.0/index.js");
const fileName = "scene.glb";
const result = await GLTF2Export.GLBAsync(scene, fileName, geometryCompressionOptions);
const root = result.files[fileName];
Expand All @@ -44,14 +39,3 @@ async function serializeGlbAsync(scene: BabylonScene, geometryCompressionOptions
}
return new File([root], fileName, { type: "model/gltf-binary", lastModified: 0 });
}

function requiresTextureTransform(texture: BaseTexture): boolean {
return (
("uOffset" in texture && texture.uOffset !== 0) ||
("vOffset" in texture && texture.vOffset !== 0) ||
("uScale" in texture && texture.uScale !== 1) ||
("vScale" in texture && texture.vScale !== 1) ||
("wAng" in texture && texture.wAng !== 0) ||
texture.coordinatesIndex !== 0
);
}
Loading