BAH-5026 | Drop the weekly cron from the Semgrep workflow - #134
Open
vishalkarmalkarthoughtworks wants to merge 1 commit into
Open
BAH-5026 | Drop the weekly cron from the Semgrep workflow#134vishalkarmalkarthoughtworks wants to merge 1 commit into
vishalkarmalkarthoughtworks wants to merge 1 commit into
Conversation
GitHub disables a scheduled workflow in a public repo after 60 days with no repository activity, and the disable applies to the whole workflow, not just the cron trigger. Bahmni/bahmni-api-test-automation and Bahmni/openmrs-module-bedmanagement had already lost Semgrep on every PR this way, and GitHub does not re-enable it when the repo becomes active again. Scanning on pull_request and on push to the default branch is unchanged, and workflow_dispatch stays for an on-demand full scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
schedule:trigger from.github/workflows/semgrep.yml. Two lines, no other change.Why
GitHub disables a scheduled workflow in a public repo after 60 days with no repository activity. Two details matter:
pull_requestandpushstop firing too, so Semgrep stops running on every PR.This already happened to two repos from this rollout.
semgrep.ymlwas in statedisabled_inactivityon Bahmni/bahmni-api-test-automation and Bahmni/openmrs-module-bedmanagement, so Semgrep had stopped running on their PRs entirely. Both have been re-enabled, and they would trip again in another 60 dormant days with the cron still in place.What is unaffected
workflow_dispatch, so an on-demand full scan is still one click in the Actions tab.Diff
Ticket: https://bahmni.atlassian.net/browse/BAH-5026