Skip to content

Extract reward registry from RewardHandler - #287

Merged
BenCodez merged 3 commits into
masterfrom
refactor/reward-registry
Aug 23, 2026
Merged

BenCodez merged 3 commits into
masterfrom
refactor/reward-registry

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

Extract registered reward state and lookup/update behavior from RewardHandler into RewardRegistry under com.bencodez.advancedcore.api.rewards.

Changes

  • add api.rewards.RewardRegistry
  • move ownership of loaded rewards, directly-defined rewards, and sub-directly-defined rewards into the registry
  • move reward lookup, direct/sub-direct lookup, duplicate detection, reward existence checks, and registered reward replacement into the registry
  • keep RewardHandler as the public compatibility facade and preserve its existing getter/method signatures
  • keep reward loading, execution, built-in inject registration, validation, and sub-reward discovery orchestration in RewardHandler for later focused refactors
  • preserve existing lookup semantics, including current case-sensitivity/case-insensitivity behavior
  • add RewardRegistryTest characterization coverage

This is intended as a behavior-preserving refactor with no reward config changes.

@BenCodez
BenCodez marked this pull request as ready for review August 23, 2026 18:31
@BenCodez
BenCodez merged commit 7bb007a into master Aug 23, 2026
4 checks passed
@BenCodez
BenCodez deleted the refactor/reward-registry branch August 23, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant