Repository navigation
Decompose RewardHandler reward services - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue the reward cleanup by extracting several cohesive responsibilities from
RewardHandlerinto focused classes undercom.bencodez.advancedcore.api.rewards.Changes
RewardLoaderRewardValidatorSubRewardResolverRewardInjectionRegistryRewardHandleras the public compatibility facade with the same existing methods delegating to the focused servicesRewardHandlerfor a later focused executor refactorRewardServicesTestcoverage for loader discovery, injection ordering, validator facade behavior, and recursive sub-reward protectionAll new classes are under
api.rewards, matching the current package layout.This is primarily a behavior-preserving organization refactor, with the intentional correctness improvement that recursive sub-reward discovery is bounded instead of recursing indefinitely.