Repository navigation
Finalize reward execution and lookup cleanup - #290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finish the current reward-subsystem cleanup in one PR by extracting reward execution, normalizing direct/sub-direct lookup behavior, and reducing
RewardHandlerto a compatibility facade plus lifecycle/UI glue.Execution
api.rewards.RewardExecutorgiveReward(...)dispatch formsapi.rewards.RewardExecutionContextRewardOptionsinternallyRewardOptionsas the public compatibility objectLookup/path consistency
RewardRegistryrewardExist(...)follow normal reward-name space/case normalizationRewardHandler cleanup
RewardHandlermethods as facade methodsRewardExecutorgetRewardExecutor()alongside the other extracted reward servicesTests
RewardRegistryTestfor case/separator/space normalization and normalized duplicate rejectionRewardExecutorTestcovering execution context naming, null options, list/string dispatch, direct/sub-direct dispatch, inline sections, command rewards, async handoff, choice rewards, and update constructionAll new classes remain under
com.bencodez.advancedcore.api.rewards.This PR includes intentional lookup consistency fixes in addition to the structural refactor; reward configuration keys and existing
RewardHandlerpublic entry points remain unchanged.