Repository navigation
Extract plugin runtime lifecycle coordination - #301
Merged
Merged
Conversation
BenCodez
marked this pull request as ready for review
August 24, 2026 23:17
|
You have reached your Codex usage limits for security reviews. Please try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move AdvancedCore runtime executor ownership and shutdown sequencing out of the large
AdvancedCorePluginclass while keeping its existing public getters as the compatibility facade.Runtime bootstrap
AdvancedCoreLifecycle.createRuntimeExecutors(...)for the Bukkit scheduler plus the existing general, login, and inventory scheduled executorsonEnable()assign the returned runtime objects to the existing plugin fields/gettersShutdown
AdvancedCoreLifecycleshutdown()+ boundedawaitTermination(...)beforeshutdownNow()FullInventoryHandlerbefore its final persistence snapshotjavaPlugin = nullinAdvancedCorePlugin.onDisable()after coordinated cleanupTests
No plugin configuration keys or public lifecycle getters are removed or renamed.