Skip to content

Pin build inputs and use least-privilege Pages deployment - #309

Merged
BenCodez merged 6 commits into
masterfrom
security/pin-build-inputs
Sep 7, 2026
Merged

BenCodez merged 6 commits into
masterfrom
security/pin-build-inputs

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the mutable third-party Javadoc publisher action with SHA-pinned official GitHub Pages actions
  • restrict workflow permissions to contents: read, pages: write, and id-token: write
  • pin the SimpleAPI snapshot dependency to the exact timestamped build currently resolved by Maven
  • add regression tests that reject mutable action references, broad content-write permissions, and mutable SimpleAPI snapshots

Testing

  • added BuildInputPinningTest to CI
  • git diff --check passes locally
  • Maven is unavailable in the local execution environment, so the repository Java CI is the authoritative full test run

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T22:59:56.420312Z 5efdbe8 Manual request
🔒 Security Review ✅ Completed 2026-09-07T21:10:12.378141Z 72e8b19 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 72e8b19545

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/publish-javadoc.yml Resolved
@BenCodez
BenCodez merged commit 19a9391 into master Sep 7, 2026
4 checks passed
@BenCodez
BenCodez deleted the security/pin-build-inputs branch September 7, 2026 22:47

BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

Addressed both review findings: the workflow now invokes maven-javadoc-plugin:3.12.0 explicitly, and the permissions assertion normalizes CRLF. Full mvn clean package passes and produces the JAR. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 19a9391a4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant