Skip to content

Require dedicated authorization for bulk player commands - #310

Merged
BenCodez merged 4 commits into
masterfrom
security/command-authorization
Sep 8, 2026
Merged

BenCodez merged 4 commits into
masterfrom
security/command-authorization

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • correctly forward the forceConsole constructor flag
  • require the granular command's .All permission before accepting the special all player target
  • retain configured administrator permissions as bulk-operation overrides
  • stop the single-player handler from running after a bulk target
  • add regression tests for console-only propagation, granular-vs-bulk permissions, and administrator overrides

Testing

  • /tmp/apache-maven-3.9.11/bin/mvn -q -Dmaven.repo.local=/tmp/m2-advancedcore -Dtest=PlayerCommandHandlerTest test
  • git diff --check

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T23:01:49.409166Z 1a2310b Manual request
🔒 Security Review ✅ Completed 2026-09-07T21:16:13.706841Z b7bdfcb PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

BenCodez commented Sep 7, 2026

Copy link
Copy Markdown
Owner Author

Added a dedicated additional-permissions API so permission-listing integrations can expose the .All permission without changing ordinary authorization semantics. The VotingPlugin /av perms integration is updated in #1599. Full mvn clean package passes. @codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 1a2310b3af

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit 5fe205b into master Sep 8, 2026
4 checks passed
@BenCodez
BenCodez deleted the security/command-authorization branch September 8, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant