Skip to content

Reduce shaded dependency duplication - #322

Merged
BenCodez merged 1 commit into
masterfrom
codex/coordinated-jar-size
Sep 12, 2026
Merged

BenCodez merged 1 commit into
masterfrom
codex/coordinated-jar-size

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • consume SimpleAPI's complete unshaded thin classifier
  • explicitly exclude unused HTTP crypto, Redis, and MQTT dependencies
  • preserve the existing relocated Hikari and Folia package ABI
  • add a package-phase test against the actual shaded JAR
  • use the current Surefire version required for JUnit 6 lifecycle correctness

Size

  • baseline: 6,331,697 bytes
  • candidate: 3,194,236 bytes
  • reduction: 3,137,461 bytes (49.55%)

Validation

  • focused: CoreRuntimeTest,AdvancedCoreUserTest — 11/11 passed
  • mvn -B -Dmaven.repo.local=... -f AdvancedCore/pom.xml clean install
    • 332 ordinary tests passed
    • packaged-artifact test passed
  • candidate JAR opens successfully and contains the expected plugin, scheduler, relocated Folia/Hikari/Rhino classes while excluding BC/HTTP/Redis/MQTT payload
  • installed candidate POM and dependency tree were inspected
  • git diff --check
  • fresh independent frozen-diff review: No findings.

Dependency gate

Blocked on the coordinated SimpleAPI PR being merged and its SNAPSHOT (including the thin classifier) being available to CI. The exact chain passed locally in dependency order using an isolated Maven repository. This PR is intentionally a draft until that upstream artifact is available.

No artifact was published and no deployment was performed.

@BenCodez
BenCodez marked this pull request as ready for review September 12, 2026 23:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-12T23:50:16.181776Z ba91171 Draft marked ready
🔒 Security Review ✅ Completed 2026-09-12T23:50:29.538240Z ba91171 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@BenCodez
BenCodez merged commit 018ad96 into master Sep 12, 2026
4 of 6 checks passed
@BenCodez
BenCodez deleted the codex/coordinated-jar-size branch September 12, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant