Skip to content

Preserve declared numeric user columns during reconciliation #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenCodez merged 7 commits into from
Sep 24, 2026
Merged

Preserve declared numeric user columns during reconciliation #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e77f295
Preserve declared numeric string storage
BenCodez Sep 24, 2026
dcaea57
Bind retained PostgreSQL values by target type
BenCodez Sep 24, 2026
55c7580
Reconcile retained numeric SQL column types
BenCodez Sep 24, 2026
c74e766
Preserve numeric column modifiers during reconciliation
BenCodez Sep 24, 2026
910a19f
Normalize retained numeric aliases
BenCodez Sep 24, 2026
8d8b282
Normalize MariaDB migration metadata
BenCodez Sep 24, 2026
96167c3
Normalize MySQL decimal defaults during schema reconciliation
coderabbitai[bot] Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...ore/src/main/java/com/bencodez/advancedcore/core/user/storage/sql/JdbcSqlUserStorage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,14 @@ private DataValue readValue(ResultSet result, int index, DataType type) throws S

private void bind(PreparedStatement statement, int index, DataValue value, SqlUserSchema.ColumnDefinition definition) throws SQLException {
if (value == null) statement.setObject(index, null);
else if (value.isString()) statement.setString(index, value.getString());
else if (value.isString()) {
// PostgreSQL's unknown parameter type lets the destination column
// parse the stored representation. This supports both ordinary text
// columns and deliberately retained numeric/boolean SQL columns whose
// public AdvancedCore value contract remains STRING.
if (dialect == Dialect.POSTGRESQL) statement.setObject(index, value.getString(), Types.OTHER);
else statement.setString(index, value.getString());
}
else if (value.isInt()) {
// PostgreSQL's unspecified parameter type is inferred from the target
// column. This preserves writes to both current integer columns and
Expand Down
Loading
Loading