Skip to content

Consolidate dependency updates and refresh Spigot API - #366

Merged
BenCodez merged 1 commit into
masterfrom
maintenance/consolidated-dependency-refresh
Oct 16, 2026
Merged

BenCodez merged 1 commit into
masterfrom
maintenance/consolidated-dependency-refresh

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Consolidates the logging and deployment-tool updates and refreshes the provided Spigot API.

  • Spigot API: 26.2 to 26.3 (provided scope).
  • slf4j-simple: 2.0.18 to 2.0.20.
  • Maven deploy plugin: 3.1.4 to 3.2.0 in all three existing profiles; deployment remains skipped.

Java 21, runtime source, shading rules and profile activation are unchanged. Supersedes #358 and #359.

Validation: clean producer package passed 1,296 unit tests and one artifact test, with zero skips. An unchanged VotingPlugin consumer at 18f2fe92b226cdb9b25aeed112925327a2dd35a3 passed 2,747 unit-test cases (one skip) and five artifact checks using the exact candidate SDK in an isolated cache; all 188 test classpaths were verified. All 1,459 AdvancedCore class names were present under the expected shaded package, and no SLF4J provider leaked into the consumer JAR. The consumer artifact exceeded its advisory 10 MiB size target. Independent review found no findings.

No Minecraft server, merge or artifact deployment was performed.

Summary by CodeRabbit

  • Chores
    • Updated the versions of the platform API and build tooling used by AdvancedCore.
    • No end-user-facing changes are included in this update.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T16:05:08.398828Z dcf2626 PR opened
🔒 Security Review ✅ Completed 2026-10-16T16:07:42.729918Z dcf2626 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 96a9fa92-511f-4e06-bdd3-e2efa9260284
📥 Commits

Reviewing files that changed from the base of the PR and between fa28aa7 and dcf2626.

📒 Files selected for processing: 1
  • AdvancedCore/pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 3
  • GitHub Check: build
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (java-kotlin)
🔇 Additional comments: 1
AdvancedCore/pom.xml: 1

276-276: LGTM!

Also applies to: 305-305, 443-443, 508-508, 572-572

📝 Walkthrough

The POM updates the Spigot API and SLF4J Simple dependency versions. It also updates the Maven Deploy Plugin version in three profiles.

Changes: POM version updates

Layer / File(s) Summary
Dependency versions
AdvancedCore/pom.xml
The Spigot API version changes to 26.3-R0.1-SNAPSHOT, and the SLF4J Simple version changes to 2.0.20.
Deploy plugin profiles
AdvancedCore/pom.xml
The Maven Deploy Plugin version changes to 3.2.0 in the deploy-snapshot, deploy, and javadoc profiles.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to dcf26

The PR updates dependency and deploy-plugin versions without changing runtime code or deployment skip settings. The supplied test reports are successful, and no actionable merge-blocking regression is identified.

### Architecture Summary

Architecture risk: 🔵 Low · up to dcf26

The change affects 1 system.

Changed systems: AdvancedCore

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — AdvancedCore (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in AdvancedCore/pom.xml: The provided spigot-api dependency version changes from 26.2-R0.1-SNAPSHOT to 26.3-R0.1-SNAPSHOT.
  • observed — Modified behavior in AdvancedCore/pom.xml: The compile-scoped slf4j-simple dependency version changes from 2.0.18 to 2.0.20.
  • observed — Modified behavior in AdvancedCore/pom.xml: The Maven Deploy Plugin version in the deploy-snapshot profile changes from 3.1.4 to 3.2.0; the surrounding skip configuration is unchanged.
  • observed — Modified behavior in AdvancedCore/pom.xml: The Maven Deploy Plugin version in the deploy profile changes from 3.1.4 to 3.2.0; the surrounding skip configuration is unchanged.
Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title accurately summarizes the dependency updates and the Spigot API refresh. It is concise and specific.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenCodez
BenCodez merged commit fdd1832 into master Oct 16, 2026
6 checks passed
@BenCodez
BenCodez deleted the maintenance/consolidated-dependency-refresh branch October 16, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant