Repository navigation
Preserve active Velocity configuration on failed reload - #104
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Problem
MCHT finding
20261002T012032106596Z-aa5ef0416165confirmed that normal Velocity YAML reload substitutes an empty root after parsing fails. VotingPlugin can consequently lose its active MQTT selection and administrator settings. This is a configuration-preservation failure, not evidence of live vote loss.Change
UncheckedIOExceptionand retains the last valid snapshot.Validation
mvn -B -f SimpleAPI/pom.xml -Dsimpleapi.mqtt.broker=/path/to/ephemeral/mosquitto clean install: 433 tests passed, including real broker restart and shared-artifact checks; full/shared/shared-sources artifacts produced.git diff --checkpassed; independent source-read-only review: No findings.VotingPlugin has a separate strict normal-reload/runtime guard, so deploying its fix does not require a simultaneous SimpleAPI API upgrade. MCHT host-side component validation remains pending execution access; no live transport/vote safety claim.