Repository navigation
Update compatible dependencies and Spigot while preserving Redis APIs - #114
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68d280122a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <groupId>redis.clients</groupId> | ||
| <artifactId>jedis</artifactId> | ||
| <version>7.5.3</version> | ||
| <version>8.0.1</version> |
There was a problem hiding this comment.
For downstream plugins that use the compile-scope Jedis dependency exposed by this POM or the Jedis classes embedded unrelocated in the full JAR, this major upgrade is source- and binary-incompatible: Jedis 8 removes JedisPooled, JedisSentineled, multiple public UnifiedJedis constructors, and other APIs, so existing consumers can fail compilation or throw linkage errors without changing their own code. The official migration guide confirms these removals; retain the compatible 7.x line or isolate/relocate the new client while preserving the former consumer surface.
AGENTS.md reference: AGENTS.md:L33-L36
Useful? React with 👍 / 👎.
BenCodez
changed the title
Updates compatible dependencies while retaining the established Redis API. Jedis stays at 7.5.3: version 8 removes public classes and constructors exposed transitively and embedded without relocation in the full artifact. Existing consumers do not need to migrate.
The compatible updates are MySQL Connector/J 26.7.0 for tests, JUnit Jupiter engine 6.1.3, Mockito 5.24.0, Maven Deploy Plugin 3.2.0 in both existing profiles, and Spigot API 26.3. Current main and its merged test-package organization are integrated with preserved history.
A package-phase regression compiles a legacy Redis consumer against only the full JAR, then checks public constructor linkage through an isolated classloader. It covers JedisPooled, JedisSentineled and UnifiedJedis without opening Redis connections. The same test fails with Jedis 8.0.1 on the missing APIs and passes with 7.5.3.
Validation on the corrected candidate:
Supersedes the compatible updates in #107, #108, #109 and #110. Original #98 is closed but explicitly EXCLUDED as an incompatible Jedis 8 update; it is not implemented by this PR. No dependency deployment or live Minecraft/database acceptance is claimed.