Repository navigation
Consolidate compatible dependency updates - #122
Merged
BenCodez merged 1 commit intoNov 3, 2026
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
BenCodez
deleted the
vp-work/simpleapi-dependency-consolidation-20261102
branch
November 3, 2026 23:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates three compatible dependency updates:
Java 21 remains the build/release target. The Velocity API is not embedded or referenced by the produced SimpleAPI classes; its Java 25 bytecode does not become a packaged runtime requirement. The legacy Jedis 7.5.3 API is retained, so #116 is not covered.
Validation: clean Java 21 package passed 466 unit tests with one optional skip, plus three full-artifact and one shared-artifact checks. Both full and shared JARs were inspected. All 359 SimpleAPI classes and 60 shared classes match the earlier tested source. The full artifact also reflects transitive annotation/logging dependency changes, including SLF4J 2.0.20; it is not byte-equivalent to the earlier dependency set. Two independent read-only reviews cover the MySQL/Surefire composition and the provided Velocity/classifier/Java follow-up, with no findings. The exact complete source tree matches those retained package/review inputs.
Full JAR SHA256: d7f6df49ee0ddf8d061eac4391c86aa56b622f569db206b50389a2fbec68f4e3.
Shared JAR SHA256: 92fca073ec8d5a4cba275fa2a89ec52fba819cc792b3aff266da2448078b62bc.
Supersedes #118, #120 and #121. Their original commits remain available through their pull-request refs. Native runtime acceptance and deployment are separate from these local package checks.