Skip to content

Update test dependencies - #191

Open
BenCodez wants to merge 1 commit into
masterfrom
vp-work/votifierplus-dependencies-20261029
Open

BenCodez wants to merge 1 commit into
masterfrom
vp-work/votifierplus-dependencies-20261029

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Updates Mockito to 5.24.0 and Maven Surefire to 3.6.1 together. The existing Velocity API remains in place for Java 21 compatibility.

Validation: 63 focused protocol and security tests and the full package of 145 tests passed. The shaded JAR passed ZIP validation and contains the Bukkit, Bungee and Velocity descriptors. An independent source review found no actionable defects.

This includes the updates from #187 and #189. The Velocity update in #190 requires a newer Java version and remains separate.

Summary by CodeRabbit

  • Chores
    • Updated project maintenance settings. No user-facing changes.

@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6d2b3dd9-929e-447d-a7c0-4950d54afb50
Commits

Reviewing files that changed from the base of the PR and between 72ed003 and 5fd1b99.

Files selected for processing: 1
  • VotifierPlus/pom.xml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: build
Additional comments: 1
VotifierPlus/pom.xml: 1

79-79: LGTM!

Also applies to: 337-337

Walkthrough

The Maven Surefire plugin version changes to 3.6.1. The test-scoped Mockito dependency version changes to 5.24.0.

Changes: Test tooling

Layer / File(s) Summary
Test tooling version updates
VotifierPlus/pom.xml
The Surefire plugin version changes to 3.6.1, and the test-scoped Mockito dependency version changes to 5.24.0.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to 5fd1b

The dependency updates are limited to test tooling, with no identified merge-blocking risk.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main changes: updates to the Mockito and Maven Surefire test dependencies.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenCodez
BenCodez marked this pull request as ready for review October 29, 2026 06:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T06:12:45.318070Z 5fd1b99 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-29T06:13:11.922759Z 5fd1b99 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant