Skip to content

Present evidence-backed Setup Doctor results - #21

Merged
BenCodez merged 1 commit into
codex/control-mockup-foundation-20260927from
codex/control-network-doctor-ui-20260927
Sep 28, 2026
Merged

BenCodez merged 1 commit into
codex/control-mockup-foundation-20260927from
codex/control-network-doctor-ui-20260927

Conversation

@BenCodez

@BenCodez BenCodez commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • present Setup Doctor diagnostics as categorized PASS / WARNING / FAIL / UNKNOWN checks
  • show the evidence source and safe navigation for each actionable result
  • validate the diagnostics response before rendering or using it in the readiness checklist
  • align the Network Health and Setup Doctor headings with the approved Control mockups
  • keep the frontend split by adding a focused network-doctor.js module

Truthful evidence boundary

This uses only the existing data.inspect.v1 diagnostics response and current Control registry/topology state. It does not claim vote-site website uptime, external Votifier port reachability, end-to-end reward health, CPU/RAM health, or general database health. Missing, truncated, or inconsistent evidence is UNKNOWN/WARNING rather than healthy.

Compatibility

  • stacked on Improve the Full YAML configuration workbench #20
  • no connector or wire-protocol change
  • no new capability
  • older connectors continue to work with their existing features; nodes without data.inspect.v1 remain capability-gated
  • all actions navigate to existing safe workflows and do not mutate configuration

Validation

  • node --check src/main/resources/web/app.js
  • node --check src/main/resources/web/network-doctor.js
  • node --test src/test/web/*.test.cjs — 128 passed
  • mvn -B -Dtest=ControlHttpServerTest test — 28 passed
  • mvn -B clean verify — 277 passed, 0 skipped
  • git diff --check
  • shaded artifact contains web/network-doctor.js
  • shaded JAR: 3,270,985 bytes
  • SHA-256: 604ec80158bb5b29a9bee4762a3ea3693cb8de4bc7575d3adc26fa66b4618c18

Review

The complete base-to-head diff was manually inspected after the final change. The opening automated review found eight valid evidence/navigation edge cases, all fixed with regressions: truncated proxy summaries now yield UNKNOWN, unavailable VoteLog adapters are distinguished from unreadable adapters, inconsistent Vote Site counts cannot pass, unsupported storage modes stay UNKNOWN, contradictory VoteLog evidence stays UNKNOWN, the downloadable legacy summary preserves UNKNOWN as null, configured-but-disabled sites retain their meaning, and remediation actions enter the correct backend workspace.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T04:26:03.685914Z 1c53c18 New commits
🔒 Security Review ✅ Completed 2026-09-28T04:01:21.757200Z 1329baa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: f6b133ea-f8f4-431e-bc3e-b1e9b7e465fc


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1329baa6b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/app.js Resolved
@BenCodez
BenCodez force-pushed the codex/control-network-doctor-ui-20260927 branch from 1329baa to c28c2bc Compare September 28, 2026 04:03

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c28c2bc40d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez force-pushed the codex/control-network-doctor-ui-20260927 branch from c28c2bc to d709722 Compare September 28, 2026 04:07

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7097228dc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez force-pushed the codex/control-network-doctor-ui-20260927 branch from d709722 to d095c80 Compare September 28, 2026 04:11

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d095c80549

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/app.js Resolved
@BenCodez
BenCodez force-pushed the codex/control-network-doctor-ui-20260927 branch from d095c80 to 7866572 Compare September 28, 2026 04:19

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7866572ea2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main/resources/web/app.js Resolved
@BenCodez
BenCodez force-pushed the codex/control-network-doctor-ui-20260927 branch from 7866572 to 1c53c18 Compare September 28, 2026 04:23
@BenCodez
BenCodez merged commit d07c603 into codex/control-mockup-foundation-20260927 Sep 28, 2026
1 check passed
@BenCodez
BenCodez deleted the codex/control-network-doctor-ui-20260927 branch September 28, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant