Skip to content

Split top voter loading and ranking #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenCodez merged 3 commits into from
Aug 26, 2026
Merged

Split top voter loading and ranking #1563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7712ea1
Split top voter loading and ranking
BenCodez Aug 26, 2026
53998ea
Restore top voter skull cache warmup
BenCodez Aug 26, 2026
5391868
Warm skull cache after all rankings finalize
BenCodez Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions VotingPlugin/src/main/java/com/bencodez/votingplugin/VotingPluginMain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ public class VotingPluginMain extends AdvancedCorePlugin {
@Getter
private long lastBackgroundTaskTimeTaken = -1;

private boolean firstTimeLoaded = false;

@Getter
@Setter
Expand All @@ -291,25 +290,7 @@ public void basicBungeeUpdate() {
}
}

public void checkFirstTimeLoaded() {
if (!firstTimeLoaded) {

if (getGui().isChestVoteTopUseSkull()) {
int maxToLoad = 200;
for (TopVoter top : getTopVoter().keySet()) {
int num = 1;
Set<TopVoterPlayer> players = getTopVoter().get(top).keySet();
for (TopVoterPlayer p : players) {
if (num <= maxToLoad) {
getSkullCacheHandler().addToCache(p.getUuid(), p.getPlayerName());
}
num++;
}
}
}
}
firstTimeLoaded = true;
}


/**
* Check votifier.
Expand Down Expand Up @@ -351,9 +332,7 @@ public void loadVoteShopManager() {
voteShopManager = new VoteShopManager(this);
}

public ArrayList<TopVoterPlayer> convertSet(Set<TopVoterPlayer> set) {
return new ArrayList<>(set);
}


@Override
public FileConfiguration getConfig() {
Expand Down Expand Up @@ -1212,7 +1191,6 @@ public synchronized void update() {
serverData.updateValues();
getSigns().updateSigns();

Comment thread
BenCodez marked this conversation as resolved.
Resolved
checkFirstTimeLoaded();

if (plugin.getConfigFile().isDiscordSRVEnabled() && getDiscordHandler() != null) {
for (TopVoter top : TopVoter.values()) {
Expand Down
Loading
Loading