Skip to content

Automate hosted Control credential enrollment - #1585

Merged
BenCodez merged 39 commits into
masterfrom
codex/automatic-control-enrollment
Aug 29, 2026
Merged

BenCodez merged 39 commits into
masterfrom
codex/automatic-control-enrollment

Conversation

@BenCodez

Copy link
Copy Markdown
Owner

Summary

  • generate a durable node credential automatically when a proxy or Bukkit node points at its own hosted Control listener
  • let plugin-messaging Bukkit backends auto-enroll in the proxy-hosted Control without copying credentials
  • keep every raw backend credential local and send only a SHA-256 verifier over a request bound to the actual Velocity/BungeeCord backend connection
  • preserve source identity across reload queues, require BungeeSettings.Server to match the real proxy server name, and rate-limit verifier installation requests
  • make blank backend NodeId reuse BungeeSettings.Server
  • retain manual enrollment for external Control deployments, custom node IDs, and non-plugin-message transports
  • document the zero-command setup and add wire, persistence, endpoint, and hosted-installer tests

Security model

The generated bearer token is written only to the node's owner-readable credential file. The child process and proxy receive only its SHA-256 verifier. Existing nonblank/manual credentials are never overwritten. Hosted artifact execution remains SHA-256 pinned and path-contained.

Dependency

Requires BenCodez/VotingPlugin-Control#4 and a VotingPlugin Control release containing the new enroll-verifier owner command.

Validation

  • git diff --check
  • default YAML files parse successfully
  • local Maven was attempted, but this environment could not resolve Maven Central; GitHub Actions is the authoritative build

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-29T19:12:05.983776Z ec15c72 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2f4bce16b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5a17634ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b692ab10f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 755b70a7ee

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit 95580dd into master Aug 29, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/automatic-control-enrollment branch August 29, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant