Repository navigation
Add bounded Network Doctor diagnostics and fix proxy settings task validation #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
63626db
Report bounded capability-negotiated setup health and proxy inventory
BenCodez 07ee936
Validate diagnostic evidence and scope proxy inventories to actual paths
BenCodez 35d0d56
Align diagnostics with runtime parsing and accept canonical proxy fil…
BenCodez 3f920f7
Use real storage enum in backend diagnostic wire fixture
BenCodez 8b2db04
Observe forwarding in existing NuVotifier without modifying it
BenCodez 7ca6de5
Account for NuVotifier online forwarding fallback destinations
BenCodez 32362ac
Keep optional health diagnostics bounded and recovery safe
BenCodez 4b5b326
Echo bounded opaque inspection attempt IDs without UUID parsing
BenCodez ed9970b
Omit incomplete Bukkit network health plugin inventories
BenCodez 7e766d4
Settle malformed proxy inspection queries with validation errors
BenCodez 4348ab8
Read backend reward health facts from SpecialRewards config
BenCodez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addBackendlooks forVoteParty.Enabled,VoteParty.VotesRequired, andResetMilestonesMonthly, but this call suppliesConfig.yml; those settings are stored inSpecialRewards.yml. A normal backend therefore omits the actual values, while any obsolete similarly named keys left inConfig.ymlcould be reported as current, causing Network Doctor to diagnose stale configuration instead of the runtime settings. Read these facts fromplugin.getSpecialRewardsConfig().getData()separately.AGENTS.md reference: AGENTS.md:L295-L297
Useful? React with 👍 / 👎.