Skip to content

Select the corrected facade for delayed entity scheduling - #1726

Closed
BenCodez wants to merge 1 commit into
masterfrom
vp-work/issue1725-scheduler-recursion
Closed

BenCodez wants to merge 1 commit into
masterfrom
vp-work/issue1725-scheduler-recursion

Conversation

@BenCodez

@BenCodez BenCodez commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

Delayed entity scheduling can overflow through the legacy FoliaLib Spigot backend. AdvancedCore embeds a duplicate SimpleAPI scheduler facade, so select the corrected SimpleAPI facade when shading and exercise the actual packaged game-mode listener in the artifact regression.

Related: #1725.

Dependency: BenCodez/SimpleAPI#115 must be accepted and its corrected SimpleAPI artifact published before this consumer can use the fix through normal dependency resolution. This PR is a draft while that dependency is outstanding. The local validation below used the candidate producer JAR with the unchanged public AdvancedCore SDK; it does not establish that the current published SimpleAPI snapshot contains the correction.

Validation on this source:

  • Full consumer package: 2,585 unit tests passed, one skipped, and all six packaged-artifact checks passed, including delayed facade scheduling and the packaged game-mode listener.
  • Candidate producer package: 473 passed, one optional external-broker test skipped; full/shared artifacts and public scheduler descriptors checked.
  • Independent read-only review completed with no findings. Source and dependency hashes match the validated candidate.
  • No live Paper/Folia server test was run; Folia entity dispatch is covered with mocks.

Summary by CodeRabbit

  • Bug Fixes
    • Improved compatibility between the packaged plugin and Bukkit/Folia scheduling, including player-associated tasks and reward eligibility checks.

Exclude the duplicate SDK facade and verify the shaded scheduler through the packaged game-mode listener.
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8182406a-f02d-4e1a-b8c9-e8b7b53783f4
📥 Commits

Reviewing files that changed from the base of the PR and between 0c83e75 and fc35810.

📒 Files selected for processing: 2
  • VotingPlugin/pom.xml
  • VotingPlugin/src/test/java/com/bencodez/votingplugin/tests/packaging/PackagedArtifactTest.java
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BenCodez BenCodez closed this Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant