Repository navigation
Conversation
Exclude the duplicate SDK facade and verify the shaded scheduler through the packaged game-mode listener.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delayed entity scheduling can overflow through the legacy FoliaLib Spigot backend. AdvancedCore embeds a duplicate SimpleAPI scheduler facade, so select the corrected SimpleAPI facade when shading and exercise the actual packaged game-mode listener in the artifact regression.
Related: #1725.
Dependency: BenCodez/SimpleAPI#115 must be accepted and its corrected SimpleAPI artifact published before this consumer can use the fix through normal dependency resolution. This PR is a draft while that dependency is outstanding. The local validation below used the candidate producer JAR with the unchanged public AdvancedCore SDK; it does not establish that the current published SimpleAPI snapshot contains the correction.
Validation on this source:
Summary by CodeRabbit