Repository navigation
Fix FoliaLib 0.5.1 scheduler fixture compilation - #1727
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
FoliaLib 0.5.1 returns
PlatformSchedulerfromFoliaLib.getImpl(). Seven test fixtures still mocked its parentServerImplementationinterface, preventing test compilation after the SimpleAPI upgrade. Use the resolved return type throughout those fixtures and their test helpers; existing assertions and production behavior are unchanged.Validation:
3.8.2-SNAPSHOTcandidate from AdvancedCore #369, resolved only from an isolated Maven cache: 2,585 regular tests passed, one optional paired-artifact integration test skipped, and all five packaged-artifact tests passed.1.0.2-20261019.030111-43and FoliaLib0.5.1. The final JAR has 20 FoliaLib classes in one relocated namespace, no original FoliaLib namespace or duplicate ZIP entries, and the corrected AdvancedCore scheduler calls verified withjavap.7240806ec08ee780645f0470de3968281ebc5898905922040ddd36e652bae32f. Its existing 10 MiB advisory target warning does not fail packaging.The AdvancedCore candidate used for this check has SHA-256
d578d63af4abd98ada525ca6cc38dd7255092c9361d339e782530a99561ef57c. This fixture correction does not establish a fix for the spectator-mode report. No live server test or dependency publication was performed.Summary by CodeRabbit