Repository navigation
Resolve FoliaLib before the failing Velocity repository - #1733
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins #2450 stops before compilation while resolving the FoliaLib 0.5.1 POM from the Velocity repository, which returns HTTP 522. Add FoliaLib’s documented official release repository before Velocity, with snapshots disabled. Existing repositories and dependency versions remain unchanged.
Maven can retain an earlier “not found” result even after a repository becomes healthy. A controlled Maven 3.9.11 regression using the project POM reproduces the observed sequence: after seeding a missing POM, the original POM without
-Uqueries only Velocity and fails;-Upermits resolution from Nexus. The updated POM resolves the genuine official POM/JAR without-Ufrom both that restored cache and a cold FoliaLib cache, making zero requests to Velocity for FoliaLib.The official and Nexus JAR containers have different hashes, but all 31 ZIP entries have identical names and uncompressed contents. The previously validated Java fixture changes are untouched.
git diff --checkpasses. An isolated offline package build passed with the full Java suite skipped, followed by all five packaged-artifact tests passing against the fresh JAR. Previous unchanged Java test evidence is reused; no fresh full-suite run or deployment was performed. Jenkins’s actual cache was not inspected; the cached-miss scenario is a reproduced explanation, not a claim about verified server state.Summary by CodeRabbit