Repository navigation
Define correction exit statuses - #45
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9178bf4cde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Keep the security model aligned with the standalone correct command while documenting that embedded correction workflows retain status 1.\n\nSecurity: the disclosure gate remains fail-closed; this change records its command-specific observable status.\n\nValidated by diff inspection. Addresses the review of #45.
|
Thanks for suggesting this one @FractalEncrypt. |
This comment has been minimized.
This comment has been minimized.
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
Concept ACK. Code looks right; not ACKing 5a826bd until the merge commits are gone.
|
Release-gate recheck: the prior Concept ACK still has one mechanical blocker. Current head remains |
5a826bd to
eb7cfdd
Compare
This comment has been minimized.
This comment has been minimized.
|
Release-gate follow-up: the earlier branch-history blocker is resolved. Current head |
2d925d6 to
8619aeb
Compare
300cc7f to
87f0ff8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87f0ff8190
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
b2aafe3 to
f8de15a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8de15a739
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f8de15a to
135c466
Compare
This comment has been minimized.
This comment has been minimized.
135c466 to
61fe0df
Compare
This comment has been minimized.
This comment has been minimized.
61fe0df to
d1ecc82
Compare
This comment has been minimized.
This comment has been minimized.
d1ecc82 to
c943e9a
Compare
This comment has been minimized.
This comment has been minimized.
4d09ad1 to
a77ab52
Compare
19a59dd to
3d5e60d
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review, posted at the maintainer's request.
ACK 3d5e60d code. Before merge, squash/rewrite the Codex-authored follow-up under the responsible human author per the AI policy.
3d5e60d to
ee752ab
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee752abfde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
70cfae4 to
7edb926
Compare
ee752ab to
bfd8b1b
Compare
7edb926 to
7c7ba26
Compare
Give standalone correction a stable status contract: 0 for already-valid input, 1 when a suggestion is emitted, 2 for command or input syntax errors, and 3 when no usable suggestion is emitted. Keep incomplete best-effort suggestions at status 1 and document status 3 only for incomplete searches without a usable suggestion. Fixes #39.
bfd8b1b to
794f898
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
Release-gate ACK 794f898.
Current head is the one human-authored focused commit on #42. The resolved review findings are present in the final tree: standalone correct uses distinct 0/1/2/3 statuses, malformed immutable HRPs are usage errors under the 1–83 BIP93/BIP173 contract, disclosure refusal/no-result paths use status 3, and emitted incomplete best-effort suggestions remain status 1. All inline threads are resolved and exact-head Python-package run 433 is green.
No remaining code blocker from this review. Review #42 first, then #45.
|
Agent release-gate review at current head |
The status-3 wording called Bitcoin Core an unavailable dependency, which reads like a Python package dependency. Name the actual optional runtime service and the ms32 path that uses it. The generic codex32 correct command remains Core-independent. Refs #39.
Fixes #39.
correctnow has a stable, documented status contract:0: input is already valid1: a correction suggestion was emitted2: command or input syntax is invalid3: no usable suggestion was emittedStatus 3 covers no result, incomplete searches with no usable suggestion, ambiguous searches, refused disclosure, and a missing dependency needed to present a suggestion. Worksheet-residue repairs return 1 when they emit repair instructions. Other commands retain their existing status behavior.
This PR is stacked on #42 because its tests include the mixed-case correction path. It is one human-authored focused commit on #42 head
7c7ba26; current #45 head is794f898. All inline review threads are resolved, including the immutable-HRP syntax check, the generalized BIP93 1–83 HRP contract, and the incomplete-search documentation qualification.Validation:
python -O;git diff --check: clean;Human review order is #42 first, then #45.
The HRP check follows the generalized BIP93 draft (
BenWestgate/bipsPR #2 @01374bf): BIP93 uses the BIP173 HRP grammar, including the 1–83 character bound; the larger limit is for the expanded checksum codeword, not the HRP.Disclosure: AI tools were used while implementing and checking review follow-ups, per
docs/developer/AI_POLICY.md.