cli: Name the real Bitcoin Core requirement when it is missing

[BenWestgate]

Problem

Without bitcoin-cli, ms32 secret, share, correct, wallet and create used the generic message “Install a reviewed bitcoin-cli before creating a backup.” It did not say what Core was needed for, what the codex32 <command> fallback omits, or that ms32 correct would spend up to ten seconds searching before discovering Core was unavailable.

Change

The Core failure now names Bitcoin Core 32+, RPC, and signet/regtest practice. secret, share, and correct explain that Core supplies the master fingerprint/correction ranking and point to the Core-independent codex32 command. create and wallet state that they give Core the master key and therefore have no fallback.

ms32 correct connects before beginning a damaged master-seed search. Core network selection is kept off redirected stdin/stderr so a pipe cannot accidentally answer an interactive network prompt.

Review stack

Base: #105 (codex/remove-unreachable-v1-branches) at 9ea48de.

Current head 27f4cc6 is the two focused #99 behavior commits replayed onto that squashed cleanup base. Both live commits record BenWestgate as author. The unrelated historical refresh/size-budget commit is not part of this PR delta.

Validation

Exact-head Python-package run 37479940117 and Bitcoin Core wallet-fixture run 37479940249 both completed successfully. The composed refreshed stack through #95 also passes all 941 tests normally and under python -O, Ruff check/format, mypy, correction-constant verification, all 57 frozen differential correction cases, and git diff --check.

Focused tests cover all three Core-independent fallback messages, the no-fallback wallet/setup path, early correct Core connection, missing bitcoin-cli, no local Core 32+ RPC, and redirected input not answering network selection.

A fresh Codex review has been requested for 27f4cc6; the prior ACK covered the pre-rewrite head and all inline threads are resolved.

Human review/integration order is #105 → #99 → #80 → #81 → #95.

Closes #84.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b738eb71e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BenWestgate]

@codex review

[BenWestgate]

CACK, will review the code after the bots say it is ready for me.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 256998066e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[BenWestgate]

AI-generated review (Codex), posted at the maintainer's request.

Not ACKing 2569980 yet: this raises the installed-code budget from 5,200 to 5,250 without the explicit authorization AGENTS.md requires. The Core error-handling change otherwise looks sound.

[BenWestgate]

AI-generated current-head follow-up review (Codex), posted at the maintainer's request.

ACK c583b2479359 for the focused #84 behavior now that the unrelated <5250 cap commit has been removed.

The error paths name Bitcoin Core 32+/RPC clearly; Core-independent codex32 fallbacks are described only for secret/share/correct; wallet/create correctly have no fallback. ms32 correct now establishes the Core boundary before spending the correction-search deadline, while already-valid input still returns before connecting. The redirected-input change prevents stdin from being consumed by Core network selection and suppresses incidental selection chatter on redirected stderr.

The behavior is covered by the missing-Core/fallback, wallet no-fallback, multi-network pipe, and Core preflight regressions. No correctness blocker found in the five-file diff.

The PR is now stacked on #105 and preserves <5200; run the final combined-tip CI after human integration/restack before freezing the candidate. Responsible-human authorship/review policy still applies.

[BenWestgate]

Codex current-head review at 70c5da6: no findings. Since the prior ACK, the only new commit brings in #105’s already exact-head-reviewed behavior-preserving cleanup; the #99 Core-error/preflight behavior is unchanged and no interaction regression is visible in the combined tree.

[BenWestgate]

AI-generated current-head stack review (Codex), posted at the maintainer's request.

Code ACK 70c5da6267bf for the actual #105 + #99 head. #105 is now an ancestor of this branch; comparing #105 (361feb7) to the current head yields exactly the five previously reviewed #84 files: _bitcoin_core.py, cli.py, test_bitcoin_core.py, test_cli.py, and test_correction_disclosure.py. The unrelated <5250 cap change is absent.

The behavior review remains unchanged: Core 32+/RPC requirements and Core-independent fallbacks are correctly described, ms32 correct establishes the Core boundary before damaged-input search, and redirected input cannot answer Core network selection.

Fresh current-head Python-package run #749 is still queued at the time of this review; current-head Bitcoin Core fixture run #37 has succeeded. Treat this as an exact-head code ACK with Python CI pending, not a claim that the matrix is already green. Responsible-human authorship/review still applies before integration.

[BenWestgate]

@codex review

Current head was mechanically restacked onto the refreshed audit stack after #57's documentation-only follow-up. Please review this exact head for correctness/regressions; the composed stack passes 941 tests normally and under python -O, Ruff, mypy, correction constants, 57 frozen differential cases, and git diff --check locally.

[BenWestgate]

@codex review

Current head was mechanically restacked onto refreshed #105; please review the current diff only.

[BenWestgate]

AI-assisted current-head review, posted at the maintainer's request.

ACK 3847389 for code review. The focused #99 behavior is unchanged after the mechanical restack: redirected input cannot drive Core network selection, redirected stderr stays quiet before the disclosure gate, and Core 32+/RPC/fallback errors remain accurate. Bitcoin Core fixture CI passes; the fresh Python-package run is still in progress. No findings.

[BenWestgate]

@codex review

Please review current head 3847389d13 only. This is the final current-head audit check before human review; do not reopen superseded design debates unless there is a correctness, security, or release-blocking issue.

[BenWestgate]

@codex review

Please review the current head 27f4cc6 only. Focus on the Core-boundary/error-message behavior and redirected stdin/stderr regressions; avoid stylistic churn.

[BenWestgate]

AI-assisted current-head review: ACK 27f4cc6. The Core boundary is explicit and consistent with the chosen v1 policy: ms32 retains Core-backed fingerprint/correction ranking, while the generic codex32 commands are the offline fallback. ms32 correct now fails before spending the correction-search budget, and redirected stdin cannot accidentally answer a multi-network prompt. The wallet/create path correctly offers no Core-independent fallback. Exact-head Python-package and Bitcoin Core fixture CI are green and all review threads are resolved. No correctness or release blocker found.