Skip to content

AP-733 Ensure Framework pushes multi-arch images#51

Open
jason-raitz wants to merge 3 commits into
mainfrom
AP-733_update_github_actions
Open

AP-733 Ensure Framework pushes multi-arch images#51
jason-raitz wants to merge 3 commits into
mainfrom
AP-733_update_github_actions

Conversation

@jason-raitz

Copy link
Copy Markdown
Contributor
  • uses .github/.github templates for build, merge, push, and release
  • which also adds support for multi-arch builds in the registry
  • bumps some github action versions
  • cleans up test job a bit
    • corrects bundle audit misname
    • adds a js:eslint step (which was not previously performed)

@jason-raitz jason-raitz self-assigned this Jun 16, 2026
@jason-raitz jason-raitz marked this pull request as ready for review June 16, 2026 18:08
 - uses .github/.github templates for build, merge, push, and release
 - which also adds support for multi-arch builds in the registry
 - bumps some github action versions
 - cleans up test job a bit
   - corrects bundle audit misname
   - adds a js:eslint step (which was not previously performed)
@jason-raitz jason-raitz force-pushed the AP-733_update_github_actions branch from 7757910 to c4d6dfd Compare June 16, 2026 18:17
@jason-raitz jason-raitz marked this pull request as draft June 16, 2026 18:24
Comment thread .github/workflows/build.yml Outdated
docker compose cp app:/opt/app/artifacts ./ || mkdir artifacts
docker compose logs > artifacts/docker-compose-services.log
docker compose config > artifacts/docker-compose.merged.yml
docker compose config > artifacts/docker-compose.docker-buildd.yml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
docker compose config > artifacts/docker-compose.docker-buildd.yml
docker compose config > artifacts/docker-compose.docker-build.yml

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I got carried away with the find/replace. I'll revert that line. I believe it's just saving the merged docker-compose.yml as an artifact.

@jason-raitz jason-raitz marked this pull request as ready for review June 16, 2026 20:33

@anarchivist anarchivist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants