Skip to content

Fix email links navigating the reader and opening repeated tabs - #30

Merged
mrinc merged 1 commit into
masterfrom
fix/email-link-navigation
Oct 1, 2026
Merged

mrinc merged 1 commit into
masterfrom
fix/email-link-navigation

Conversation

@bcbetterninja

Copy link
Copy Markdown
Collaborator

Clicking an email link could navigate the embedded reader and open additional browser tabs as the destination redirected. Keep the email visible and launch the external browser once per click, including links requesting a new window and cases where the OS launcher fails or returns no process handle. Apply the same shared handling to the notes reader.

Avalonia WebView 12.1.0’s GTK adapter returns a handled policy result without explicitly rejecting the WebKit navigation. Add a lifecycle-managed GTK policy handler that calls webkit_policy_decision_ignore and only launches external links for actual user clicks. Redirects and script navigation cannot launch more tabs; local documents and image loading remain supported.

Validation:

  • Solution and UI preview builds passed with zero warnings/errors.
  • All 553 tests passed, including cancellation independent of browser launch success.
  • Real Linux WebKit regression passed using synthetic mail and a loopback redirect server: one launch per click, unchanged email content, zero redirect requests, new-window links, launcher failure, script navigation, and view reattachment.
  • Added the Linux regression check to CI. No private email content or screenshots are included.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3243f9af-44e9-4357-98a3-e22ec6139080

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mrinc
mrinc merged commit e1a0536 into master Oct 1, 2026
9 checks passed
@mrinc
mrinc deleted the fix/email-link-navigation branch October 1, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants